©1996-2012 Roedy Green, Canadian Mind ProductsHere is an email I received in response to my essay on how to write unmaintainable code.
It defines a union of char[4]; and uint, inititializes the int using a function call, then the argument to return is a huge single line of &&, ||, <<, >>, <, >, == etc. operators. The idea is to return a boolean value. The single comment is /* cool hack, gene */
Now, I don’t really have a problem with the union, nor the long gross return. The real heinousness is that all the test values are literals! Have a little typo accident with emacs, vi or msvc or whatever anywhere in that line, and you get a virtually untraceable bug! The code will compile and run just fine changing values or operators willy nilly! It will even work correctly most of the time!
There is of course, not test function written for this code. Even better, the author is now CEO (Chief Executive Officer) at a startup…
Uh oh… boss just drove in…
 |
You can get the freshest copy of this page from: | or possibly from your local J: drive (Java virtual drive/mindprod.com website mirror) |
| http://mindprod.com/feedback/unmain/union.html | J:\mindprod\feedback\unmain\union.html | |
 |  Please email your feedback for publication, letters to the editor, errors, omissions, typos, formatting errors, ambiguities, unclear wording, broken/redirected link reports, suggestions to improve this page or comments to
Roedy Green :
If you want your message kept confidential, not considered for posting, please explicitly specify that. | |
| Canadian Mind Products | ||
| mindprod.com IP:[65.110.21.43] | ||
| view | Your face IP:[38.107.179.210] | |
| Feedback | You are visitor number 11. | |
